Skip to content

Add arcpro runner#133

Open
geogeek11 wants to merge 13 commits intomasterfrom
occamlabsarcpro
Open

Add arcpro runner#133
geogeek11 wants to merge 13 commits intomasterfrom
occamlabsarcpro

Conversation

@geogeek11
Copy link
Copy Markdown

Add ArcPro runner to the controller;

@geogeek11 geogeek11 requested review from arahman-ma and shurst-ma and removed request for arahman-ma January 15, 2022 14:34
' method cannot be called directly')

def _get_all_templates_by_regex(self, recipe):
def _get_all_templates_by_regex(self, recipe): #Todo should we use the layoutManager from project instance
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function _get_all_templates_by_regex has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

return versionNumber

# Is it possible to avoid the need to hardcode the naming convention for the output mxds? Eg could a
# TODO Is it possible to aviod the need to hardcode the naming convention for the output mxds? Eg could a
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO found

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit aa461f0 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Bug Risk 1

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant